Fix incorrect _ONEDPL_SYCL_USM_HOST_PRESENT usage in USM allocation helpers #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SYCL_USM_HOST_PRESENT Signed-off-by: Matthew Michel <matthew.michel@intel.com>
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
|
@mmichel11 Thanks for raising this. I noticed several issues as well and am working on fixes for them. Namely:
I have a WIP branch here |
|
I believe #1503 supersedes this PR by including this macro fix and several other fixes. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__use_USM_allocationsintroduced in PR #1354 uses_ONEDPL_SYCL_USM_HOST_PRESENTto check if host memory support is present. However, this macro was renamed to_ONEDPL_SYCL_UNIFIED_USM_BUFFER_PRESENTin PR #1410, so the function always returns false. This causes incompatible scratch and result buffer paths to be taken in the code causing incorrect results and hangs.This PR switches to use the correct macro here.